Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3676 - Module builder export and file template. #3678

Merged
merged 2 commits into from
Jun 12, 2017

Conversation

Dillon-Brown
Copy link
Contributor

@Dillon-Brown Dillon-Brown commented Jun 8, 2017

Description

This change fixes modules returning a 500 error when attempting to export on PHP 7.1. This change also fixes modules created with the file template not allowing the user to create a record.

Issue ref: #3684
Issue ref: #3676

How To Test This

  1. Create a module in module builder based of file template.
  2. Attempt to create a record inside this module.
  3. Attempt to export a module in module builder on PHP 7.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@Dillon-Brown Dillon-Brown added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Jun 9, 2017
@samus-aran samus-aran merged commit 73990d3 into salesagility:hotfix Jun 12, 2017
@samus-aran samus-aran added the LTS label Jun 12, 2017
@Dillon-Brown Dillon-Brown removed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member LTS labels Sep 6, 2017
@horus68 horus68 mentioned this pull request Sep 20, 2017
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants